Review and merge PR #234 — CI workflow gating PRs on typecheck and lint #342

Closed
opened 2026-04-10 11:14:15 -04:00 by pook · 1 comment
Owner

PR #234 adds a CI workflow that gates PRs on passing typecheck and lint. Without this, broken code can merge to main and block all future development.

Acceptance criteria:

  • Review PR #234 for correct GitHub Actions workflow syntax
  • Verify workflow runs on pull_request events targeting main
  • Confirm it runs npx tsc --noEmit and lint command
  • Check that the workflow fails the PR if either check fails
  • Merge if all checks pass

Note: PR #261 (Jest + typecheck fix, tracked by #313) should merge first to ensure typecheck passes.


Generated by CEO Planner (priority: 3)

PR #234 adds a CI workflow that gates PRs on passing typecheck and lint. Without this, broken code can merge to main and block all future development. Acceptance criteria: - Review PR #234 for correct GitHub Actions workflow syntax - Verify workflow runs on pull_request events targeting main - Confirm it runs `npx tsc --noEmit` and lint command - Check that the workflow fails the PR if either check fails - Merge if all checks pass Note: PR #261 (Jest + typecheck fix, tracked by #313) should merge first to ensure typecheck passes. --- *Generated by CEO Planner (priority: 3)*
Author
Owner

Closed 2026-04-10 final triage pass.

Either the referenced PR is already closed (conflicts with main), or this is a worker-tail task spawned after CEO was paused. Surviving active work tracked by #350 (PR #340 webhook rate limiting) and #351 (PR #336 /generate rate limiting).

Pipeline state: 14 open PRs, CEO paused until PR review pass is complete. Shim /shim/ceo now fetches open issues/PRs and injects into prompt to prevent this duplication loop recurring.

Closed 2026-04-10 final triage pass. Either the referenced PR is already closed (conflicts with main), or this is a worker-tail task spawned after CEO was paused. Surviving active work tracked by #350 (PR #340 webhook rate limiting) and #351 (PR #336 /generate rate limiting). Pipeline state: 14 open PRs, CEO paused until PR review pass is complete. Shim `/shim/ceo` now fetches open issues/PRs and injects into prompt to prevent this duplication loop recurring.
pook closed this issue 2026-04-10 15:12:47 -04:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pook/compliancebot#342
No description provided.