Replace stale #292 — add document request preprocessing with documentType enum and input sanitization #323

Closed
opened 2026-04-10 08:54:02 -04:00 by pook · 1 comment
Owner

Original #292 stale 7h. Create src/middleware/preprocess-generate.ts that validates and sanitizes POST /api/generate request bodies before they reach OpenAI. Acceptance: (1) Validate documentType is one of ['privacy_policy', 'terms_of_service', 'cookie_policy'] — return 400 with { error: 'Invalid documentType. Must be: privacy_policy, terms_of_service, or cookie_policy' } for invalid values. (2) Strip HTML tags from all string inputs using a simple regex replace. (3) Trim and collapse whitespace. (4) Enforce max input length of 10000 chars for businessDetails fields — return 413 if exceeded. (5) Unit tests for each validation case. Files: src/middleware/preprocess-generate.ts, tests/middleware/preprocess-generate.test.ts.


Generated by CEO Planner (priority: 2)

Original #292 stale 7h. Create src/middleware/preprocess-generate.ts that validates and sanitizes POST /api/generate request bodies before they reach OpenAI. Acceptance: (1) Validate documentType is one of ['privacy_policy', 'terms_of_service', 'cookie_policy'] — return 400 with { error: 'Invalid documentType. Must be: privacy_policy, terms_of_service, or cookie_policy' } for invalid values. (2) Strip HTML tags from all string inputs using a simple regex replace. (3) Trim and collapse whitespace. (4) Enforce max input length of 10000 chars for businessDetails fields — return 413 if exceeded. (5) Unit tests for each validation case. Files: src/middleware/preprocess-generate.ts, tests/middleware/preprocess-generate.test.ts. --- *Generated by CEO Planner (priority: 2)*
Author
Owner

Bulk-closed 2026-04-10 during pipeline triage.

Context: CEO agent had created 100 open agent-task issues against compliancebot, largely duplicates of each other and of the 50 currently-open PRs. Root cause traced to a git-push race in agent-worker executor (dispatch jobs collided on branch agent/dispatch/* because jobId prefix truncated to literal "dispatch"). Fix deployed: runId is now threaded from Paperclip shim through /dispatch → TaskJob → executor, and branches are keyed on a 12-char unique run key.

What to do next:

  1. Triage the 50 open PRs at https://192.168.183.110:3000/pook/compliancebot/pulls — many are ready to merge
  2. CEO should halt new task creation until open PRs drop below 10
  3. Surviving kept issues: #313, #314, #315, #341, #342, #350, #351, #352 (PR review/merge tasks)

This issue was superseded, not abandoned. Reopen if still relevant after PR triage.

Bulk-closed 2026-04-10 during pipeline triage. **Context:** CEO agent had created 100 open agent-task issues against compliancebot, largely duplicates of each other and of the 50 currently-open PRs. Root cause traced to a git-push race in agent-worker executor (dispatch jobs collided on branch `agent/dispatch/*` because jobId prefix truncated to literal "dispatch"). Fix deployed: runId is now threaded from Paperclip shim through /dispatch → TaskJob → executor, and branches are keyed on a 12-char unique run key. **What to do next:** 1. Triage the 50 open PRs at https://192.168.183.110:3000/pook/compliancebot/pulls — many are ready to merge 2. CEO should halt new task creation until open PRs drop below 10 3. Surviving kept issues: #313, #314, #315, #341, #342, #350, #351, #352 (PR review/merge tasks) This issue was superseded, not abandoned. Reopen if still relevant after PR triage.
pook closed this issue 2026-04-10 14:47:45 -04:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pook/compliancebot#323
No description provided.