Replace stale #299 — add global Express error handler returning structured JSON #346

New issue

Closed

opened 2026-04-10 11:33:21 -04:00 by pook · 1 comment

pook commented

2026-04-10 11:33:21 -04:00

Owner

Issue #299 stalled. Specific fix: add a 4-parameter error handler (err, req, res, next) as the last middleware in the Express chain. Return { error: 'Internal server error', requestId: req.id || null } with status 500. If err.status exists (e.g. 413, 429), forward that status instead. Log err.message and err.stack via structured logger. Do NOT expose err.message in production response. Add integration test using next(new Error('test')) confirming 500 with correct JSON shape. Acceptance: unhandled errors return consistent JSON, no stack traces leaked.

Generated by CEO Planner (priority: 3)

Issue #299 stalled. Specific fix: add a 4-parameter error handler `(err, req, res, next)` as the last middleware in the Express chain. Return `{ error: 'Internal server error', requestId: req.id || null }` with status 500. If err.status exists (e.g. 413, 429), forward that status instead. Log `err.message` and `err.stack` via structured logger. Do NOT expose err.message in production response. Add integration test using `next(new Error('test'))` confirming 500 with correct JSON shape. Acceptance: unhandled errors return consistent JSON, no stack traces leaked. --- *Generated by CEO Planner (priority: 3)*

pook added the

agent-task

label

2026-04-10 11:33:21 -04:00

agent-bot referenced this issue from a commit

2026-04-10 11:49:45 -04:00

feat: issue #346 issue-299-stalled-specific-fix-add-a-4-p (agent task agent-ta)

pook commented

2026-04-10 14:47:44 -04:00

Author

Owner

Bulk-closed 2026-04-10 during pipeline triage.

Context: CEO agent had created 100 open agent-task issues against compliancebot, largely duplicates of each other and of the 50 currently-open PRs. Root cause traced to a git-push race in agent-worker executor (dispatch jobs collided on branch agent/dispatch/* because jobId prefix truncated to literal "dispatch"). Fix deployed: runId is now threaded from Paperclip shim through /dispatch → TaskJob → executor, and branches are keyed on a 12-char unique run key.

What to do next:

Triage the 50 open PRs at https://192.168.183.110:3000/pook/compliancebot/pulls — many are ready to merge
CEO should halt new task creation until open PRs drop below 10
Surviving kept issues: #313, #314, #315, #341, #342, #350, #351, #352 (PR review/merge tasks)

This issue was superseded, not abandoned. Reopen if still relevant after PR triage.

Bulk-closed 2026-04-10 during pipeline triage. **Context:** CEO agent had created 100 open agent-task issues against compliancebot, largely duplicates of each other and of the 50 currently-open PRs. Root cause traced to a git-push race in agent-worker executor (dispatch jobs collided on branch `agent/dispatch/*` because jobId prefix truncated to literal "dispatch"). Fix deployed: runId is now threaded from Paperclip shim through /dispatch → TaskJob → executor, and branches are keyed on a 12-char unique run key. **What to do next:** 1. Triage the 50 open PRs at https://192.168.183.110:3000/pook/compliancebot/pulls — many are ready to merge 2. CEO should halt new task creation until open PRs drop below 10 3. Surviving kept issues: #313, #314, #315, #341, #342, #350, #351, #352 (PR review/merge tasks) This issue was superseded, not abandoned. Reopen if still relevant after PR triage.

pook closed this issue

2026-04-10 14:47:44 -04:00

No labels

agent-task

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

pook/compliancebot#346

No description provided.

Rows
Columns