Add smoke test verifying /api/generate rejects unauthenticated and malformed requests #117

Closed
opened 2026-04-08 20:23:55 -04:00 by pook · 1 comment
Owner

ComplianceBot has zero merged PRs and 20 open PRs. A minimal smoke test establishes a CI baseline that the quality gate (#92 PR) can enforce.

What to implement

  1. Add a test file tests/generate-smoke.test.ts
  2. Test: POST /api/generate without auth → returns 401 or 403
  3. Test: POST /api/generate with invalid Content-Type → returns 400 or 415
  4. Test: GET /api/generate → returns 404 or 405
  5. Use supertest against the Express app without starting a real server

Acceptance criteria

  • Tests pass with npm test and require no external API keys or database connections
  • Tests validate the endpoint exists and rejects unauthorized/malformed requests
  • No AI service mocking needed — tests only hit the request validation layer
  • tsc --noEmit passes

Generated by CEO Planner (priority: 3)

ComplianceBot has zero merged PRs and 20 open PRs. A minimal smoke test establishes a CI baseline that the quality gate (#92 PR) can enforce. ## What to implement 1. Add a test file `tests/generate-smoke.test.ts` 2. Test: POST /api/generate without auth → returns 401 or 403 3. Test: POST /api/generate with invalid Content-Type → returns 400 or 415 4. Test: GET /api/generate → returns 404 or 405 5. Use supertest against the Express app without starting a real server ## Acceptance criteria - Tests pass with `npm test` and require no external API keys or database connections - Tests validate the endpoint exists and rejects unauthorized/malformed requests - No AI service mocking needed — tests only hit the request validation layer - `tsc --noEmit` passes --- *Generated by CEO Planner (priority: 3)*
Author
Owner

Bulk-closed 2026-04-10 during pipeline triage.

Context: CEO agent had created 100 open agent-task issues against compliancebot, largely duplicates of each other and of the 50 currently-open PRs. Root cause traced to a git-push race in agent-worker executor (dispatch jobs collided on branch agent/dispatch/* because jobId prefix truncated to literal "dispatch"). Fix deployed: runId is now threaded from Paperclip shim through /dispatch → TaskJob → executor, and branches are keyed on a 12-char unique run key.

What to do next:

  1. Triage the 50 open PRs at https://192.168.183.110:3000/pook/compliancebot/pulls — many are ready to merge
  2. CEO should halt new task creation until open PRs drop below 10
  3. Surviving kept issues: #313, #314, #315, #341, #342, #350, #351, #352 (PR review/merge tasks)

This issue was superseded, not abandoned. Reopen if still relevant after PR triage.

Bulk-closed 2026-04-10 during pipeline triage. **Context:** CEO agent had created 100 open agent-task issues against compliancebot, largely duplicates of each other and of the 50 currently-open PRs. Root cause traced to a git-push race in agent-worker executor (dispatch jobs collided on branch `agent/dispatch/*` because jobId prefix truncated to literal "dispatch"). Fix deployed: runId is now threaded from Paperclip shim through /dispatch → TaskJob → executor, and branches are keyed on a 12-char unique run key. **What to do next:** 1. Triage the 50 open PRs at https://192.168.183.110:3000/pook/compliancebot/pulls — many are ready to merge 2. CEO should halt new task creation until open PRs drop below 10 3. Surviving kept issues: #313, #314, #315, #341, #342, #350, #351, #352 (PR review/merge tasks) This issue was superseded, not abandoned. Reopen if still relevant after PR triage.
pook closed this issue 2026-04-10 14:48:29 -04:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pook/compliancebot#117
No description provided.