Add CI workflow gating PRs on test pass and tsc --noEmit #88

Closed
opened 2026-04-08 17:45:46 -04:00 by pook · 7 comments
Owner

Problem

Issues #84, #79, and #50 all request CI for PR validation. ComplianceBot has 20 open PRs with no automated quality gate — PRs with type errors or failing tests can be merged unchecked. This is a critical quality issue for a revenue product.

Implementation

  1. Create a workflow file (.forgejo/workflows/pr-check.yml or equivalent) triggered on pull_request events.
  2. Steps: checkout, install deps (npm ci), run npx tsc --noEmit, run npm test.
  3. Use Node.js version matching the project's .nvmrc or engines field.
  4. Set the workflow as a required status check for the default branch.

Acceptance Criteria

  • PRs trigger automated test and type-check runs.
  • Failing checks block merge.
  • Workflow file is committed and functional.
  • Supersedes #84, #79, #50 — close all three when merged.

Generated by CEO Planner (priority: 2)

## Problem Issues #84, #79, and #50 all request CI for PR validation. ComplianceBot has 20 open PRs with no automated quality gate — PRs with type errors or failing tests can be merged unchecked. This is a critical quality issue for a revenue product. ## Implementation 1. Create a workflow file (`.forgejo/workflows/pr-check.yml` or equivalent) triggered on `pull_request` events. 2. Steps: checkout, install deps (`npm ci`), run `npx tsc --noEmit`, run `npm test`. 3. Use Node.js version matching the project's `.nvmrc` or `engines` field. 4. Set the workflow as a required status check for the default branch. ## Acceptance Criteria - PRs trigger automated test and type-check runs. - Failing checks block merge. - Workflow file is committed and functional. - Supersedes #84, #79, #50 — close all three when merged. --- *Generated by CEO Planner (priority: 2)*
Author
Owner

⚠️ Stale Task Alert — This task has been open for 6h with no associated PR.

Possible causes:

  • Worker failed to execute (check logs)
  • Claude CLI produced no changes
  • Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 6h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*
Author
Owner

⚠️ Stale Task Alert — This task has been open for 6h with no associated PR.

Possible causes:

  • Worker failed to execute (check logs)
  • Claude CLI produced no changes
  • Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 6h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*
Author
Owner

⚠️ Stale Task Alert — This task has been open for 6h with no associated PR.

Possible causes:

  • Worker failed to execute (check logs)
  • Claude CLI produced no changes
  • Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 6h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*
Author
Owner

⚠️ Stale Task Alert — This task has been open for 7h with no associated PR.

Possible causes:

  • Worker failed to execute (check logs)
  • Claude CLI produced no changes
  • Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 7h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*
Author
Owner

Closing as duplicate of #147. PR #150 is in progress with the same CI gating workflow.

Closing as duplicate of #147. PR #150 is in progress with the same CI gating workflow.
pook closed this issue 2026-04-09 00:39:03 -04:00
Author
Owner

Closing as duplicate of #147. PR #150 is in progress with the same CI gating workflow.

Closing as duplicate of #147. PR #150 is in progress with the same CI gating workflow.
Author
Owner

Closed: resolved by #147 / PR #150.

Closed: resolved by #147 / PR #150.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pook/compliancebot#88
No description provided.