pook/compliancebot
1
0
Fork 0
Code Issues 1.1k Pull requests 82 Projects Releases Packages Wiki Activity Actions

fix: preserve raw body bytes for Stripe webhook signature verification #85

Merged
pook merged 1 commit from fix/webhook-raw-body-preservation into main 2026-04-09 06:14:26 -04:00
Conversation 2 Commits 1 Files changed 2 +214 -1
pook commented 2026-04-08 17:41:37 -04:00
Owner
Copy link

Summary

  • Use Buffer.from(arrayBuffer()) instead of c.req.text() in the webhook route to preserve exact raw bytes for Stripe HMAC signature verification
  • Text decoding/re-encoding can alter bytes and break stripe.webhooks.constructEvent() checks
  • Adds comprehensive integration tests for signed, tampered, expired, and missing signature scenarios

Closes #78, closes #71. Unblocks #72 and #53 (payment flow).

Changes

  • packages/api/src/routes/billing.ts — raw body preservation via arrayBuffer()
  • packages/api/tests/e2e/webhook.test.ts — new test suite (7 test cases)

Test plan

  • Verify signature passes with correctly signed payload
  • Verify tampered payloads are rejected
  • Verify expired signatures are rejected
  • Verify wrong-secret signatures are rejected
  • Verify missing signature header returns 400
  • Verify unicode payloads preserve raw bytes
  • Verify other billing routes (checkout, usage) still parse JSON normally
  • Test with Stripe CLI: stripe trigger checkout.session.completed

🤖 Generated with Claude Code

## Summary - Use `Buffer.from(arrayBuffer())` instead of `c.req.text()` in the webhook route to preserve exact raw bytes for Stripe HMAC signature verification - Text decoding/re-encoding can alter bytes and break `stripe.webhooks.constructEvent()` checks - Adds comprehensive integration tests for signed, tampered, expired, and missing signature scenarios Closes #78, closes #71. Unblocks #72 and #53 (payment flow). ## Changes - `packages/api/src/routes/billing.ts` — raw body preservation via `arrayBuffer()` - `packages/api/tests/e2e/webhook.test.ts` — new test suite (7 test cases) ## Test plan - [ ] Verify signature passes with correctly signed payload - [ ] Verify tampered payloads are rejected - [ ] Verify expired signatures are rejected - [ ] Verify wrong-secret signatures are rejected - [ ] Verify missing signature header returns 400 - [ ] Verify unicode payloads preserve raw bytes - [ ] Verify other billing routes (checkout, usage) still parse JSON normally - [ ] Test with Stripe CLI: `stripe trigger checkout.session.completed` 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix: preserve raw body bytes for Stripe webhook signature verification
Some checks are pending
agent-worker/pr-tests Running PR tests...
3b69196d4b 
Use Buffer.from(arrayBuffer()) instead of c.req.text() to ensure the
exact raw bytes are passed to stripe.webhooks.constructEvent(). Text
decoding can alter bytes and break HMAC signature checks.

Adds integration tests for signed, tampered, expired, and missing
signature scenarios. Closes #78, #71.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pook commented 2026-04-08 17:41:49 -04:00
Author
Owner
Copy link

⚠️ No Test Suite Detected

Commit: 3b69196d

No test script found in package.json. Add a test script to enable automated testing.

## ⚠️ No Test Suite Detected **Commit:** `3b69196d` No `test` script found in `package.json`. Add a test script to enable automated testing.
pook commented 2026-04-08 17:58:02 -04:00
Author
Owner
Copy link

This is the surviving PR for the Stripe webhook raw body fix. Duplicate PRs #89, #81, #75 have been closed. Duplicate issues #83, #78, #71 have been closed in favor of #87.

Review summary:

  • PR #89: Same fix, fewer tests (5 vs 9) → closed
  • PR #81: Over-engineered with separate middleware file → closed
  • PR #75: Did not fix raw body issue (still used c.req.text()) → closed

This PR correctly uses Buffer.from(await c.req.arrayBuffer()) to preserve exact raw bytes for HMAC verification, with 9 comprehensive tests.

Closes #87

This is the surviving PR for the Stripe webhook raw body fix. Duplicate PRs #89, #81, #75 have been closed. Duplicate issues #83, #78, #71 have been closed in favor of #87. **Review summary:** - PR #89: Same fix, fewer tests (5 vs 9) → closed - PR #81: Over-engineered with separate middleware file → closed - PR #75: Did not fix raw body issue (still used `c.req.text()`) → closed This PR correctly uses `Buffer.from(await c.req.arrayBuffer())` to preserve exact raw bytes for HMAC verification, with 9 comprehensive tests. Closes #87
pook merged commit ca0e140225 into main 2026-04-09 06:14:24 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent-task

Task for autonomous agent execution

  
agent-task

Paperclip autonomous agent task

No labels
agent-task
agent-task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pook/compliancebot!85
No description provided.