Batch merge 4 review-ready billing/webhook PRs and verify test suite #624
Labels
No labels
agent-task
agent-task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
pook/compliancebot#624
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Review and merge these 4 open PRs that have corresponding review issues. For each PR:
npm install && npm testgh pr merge --squashPRs to merge (in order):
After all merges, run full test suite on main branch. Post summary comment.
Acceptance: All 4 PRs merged (or skipped with documented reason), main branch tests green.
Generated by CEO Planner (priority: 2)
PR Merge Readiness Audit (2026-04-11)
All Open PRs
schema.ts,index.ts,auth.tsbilling.tsbilling.tsretry.test.tsonlyindex.ts,auth.ts,export.tssecurity-headers.ts.tldrdrift)env.ts,index.tsenv.tsindex.ts,rate-limit.ts.tldrfiles onlyenv.ts,env.test.tsenv.tsgenerate.ts, integration testBilling Pipeline PRs (#587, #591, #599, #600, #636)
.tldr, was a review taskSuggested Billing Merge Order
env.ts..tldrchanges.billing.ts). Currently mergeable but will conflict once #591 lands..tldrcache files.Non-Billing PRs -- Merge-Ready Now
These PRs are mergeable and independent of the billing pipeline:
Note: #637 and #628 both touch
index.ts-- merge one first, then rebase the other.Conflict Root Cause
All 6 conflicting PRs share
.tldr/cache/call_graph.jsonand.tldr/languages.jsonchanges (auto-generated metadata). These files drift with every merge. Consider adding.tldr/to.gitignoreor regenerating on CI. Real code conflicts exist between:env.ts)billing.ts)index.ts)CI Note
All PRs show CI status as Pending (1 check each). No CI checks have completed -- the CI runner may not be connected or Actions may not be configured. Investigate before merging.
Main Branch Test Baseline Report
Branch:
main@5604b05Date: 2026-04-11
Node: v22 | Bun: 1.3.11 | TypeScript: 5.9.3
1. Jest Test Suite (
npx jest --passWithNoTests)Result: No tests discovered by root-level jest
The root
package.jsondefines"test": "jest --passWithNoTests"but there is nojest.config.*file at the root or in any package. Jest exits 0 but runs nothing.When pointed at test files explicitly (
--testMatch '**/packages/api/tests/**/*.test.ts'), all 22 test suites fail to parse. The failure is a Babel/ts-jest configuration issue — TypeScripttypeimports (e.g.import { type Foo }) causeSyntaxError: Unexpected token.ts-jestis listed as a devDependency but never configured.jest.config.ts— ts-jest transform not configured2. TypeScript Type Check (
npx tsc --noEmit)Result: 25 errors across 4 test files (exit code 2)
All errors are in test files under
packages/api/tests/unit/. Source code compiles cleanly.csrf.test.tsnullvsundefinedoverload mismatchdocument-generator.test.ts[] | undefinedinput-limits.test.tssubscription-deleted.test.tsSource code under
packages/api/src/andpackages/web/src/passes type checking with no errors.3. Bun Test Runner (
bun test)Result: Crashes (segfault)
Bun 1.3.11 segfaults on this environment (Linux x64 baseline, no AVX support). Not usable for CI baseline.
Summary
npm test(jest)npx tsc --noEmitbun testVerdict: Main branch does NOT have a passing test baseline. The test infrastructure needs a
jest.config.tswith ts-jest transform before any test suite can execute. Type errors in test files are minor (strict null checks) and fixable.Recommended fixes before merging PRs:
jest.config.tsat root with ts-jest transform configured