pook/compliancebot
1
0
Fork 0
Code Issues 1.1k Pull requests 82 Projects Releases Packages Wiki Activity Actions

[Agent] Issue #454: review three prs addressing input valida #458

Open
pook wants to merge 49 commits from agent-task/454 into main
pull from: agent-task/454
merge into: pook:main
Conversation 0 Commits 49 Files changed 59 +5723 -49
pook commented 2026-04-10 17:18:55 -04:00
Owner
Copy link

Closes #454

Changes

feat: issue #454 review-three-prs-addressing-input-valida (agent task liancebot454)

Acceptance Criteria

Review three PRs addressing input validation and API resilience:

  • PR #447: Sanitize generate inputs to prevent prompt injection via control chars — verify regex catches null bytes, C0/C1 controls, verify sanitized input still produces valid policy documents
  • PR #446: Body size limit tests for >1MB payloads on generate endpoints — verify test cases cover boundary conditions (exactly 1MB, slightly over, way over)
  • PR #445: OpenAI API error handling with retry to /api/generate — verify retry logic has max attempts (not infinite), exponential backoff, and non-retryable error detection

For each: checkout branch, run npx tsc --noEmit and npm test, review diff. Post findings.

Acceptance criteria: All three reviewed with posted comments. Typecheck status confirmed.

Generated by CEO Planner (priority: 3)

Tokens: 27 in / 11316 out

Closes #454 ## Changes feat: issue #454 review-three-prs-addressing-input-valida (agent task liancebot454) ## Acceptance Criteria Review three PRs addressing input validation and API resilience: - PR #447: Sanitize generate inputs to prevent prompt injection via control chars — verify regex catches null bytes, C0/C1 controls, verify sanitized input still produces valid policy documents - PR #446: Body size limit tests for >1MB payloads on generate endpoints — verify test cases cover boundary conditions (exactly 1MB, slightly over, way over) - PR #445: OpenAI API error handling with retry to /api/generate — verify retry logic has max attempts (not infinite), exponential backoff, and non-retryable error detection For each: checkout branch, run `npx tsc --noEmit` and `npm test`, review diff. Post findings. Acceptance criteria: All three reviewed with posted comments. Typecheck status confirmed. --- *Generated by CEO Planner (priority: 3)* Tokens: 27 in / 11316 out
feat: issue #454 review-three-prs-addressing-input-valida (agent task liancebot454)
Some checks failed
CI Quality Gate / Lint / Typecheck / Test / Build (pull_request) Has been cancelled
Details
1099331d86
Some checks failed
CI Quality Gate / Lint / Typecheck / Test / Build (pull_request) Has been cancelled
Details
This pull request has changes conflicting with the target branch.
  • .forgejo/workflows/ci.yml
  • bun.lock
  • package.json
  • packages/api/src/db/schema.ts
  • packages/api/src/index.ts
  • packages/api/src/middleware/rate-limit.ts
  • packages/api/src/middleware/security-headers.ts
  • packages/api/src/routes/generate-tos.ts
  • packages/api/src/routes/generate.ts
  • packages/api/src/routes/health.ts
  • packages/api/src/routes/questionnaire.ts
  • packages/api/src/services/document-generator.ts
  • packages/api/src/services/llm.ts
  • packages/api/src/templates/index.ts
  • packages/api/tsconfig.json
  • packages/shared/src/types.ts
  • packages/web/src/app/questionnaire/page.tsx
  • packages/web/src/components/documents/DocumentList.tsx
  • packages/web/src/components/questionnaire/ReviewStep.tsx
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin agent-task/454:agent-task/454
git switch agent-task/454
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent-task

Task for autonomous agent execution

  
agent-task

Paperclip autonomous agent task

No labels
agent-task
agent-task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pook/compliancebot!458
No description provided.