Add Stripe webhook signature verification middleware to POST /api/billing/webhook #1229

New issue

Open

opened 2026-04-13 01:03:34 -04:00 by pook · 16 comments

pook commented 2026-04-13 01:03:34 -04:00

Owner

Copy link

SECURITY CRITICAL: The compliancebot billing webhook route has no signature verification. Without this, any attacker can send fake Stripe events to create subscriptions, grant access, or corrupt billing state. This is the #1 OWASP API security risk.

Implementation:

1. Create src/middleware/verify-stripe-signature.ts
2. Read Stripe-Signature header from incoming request
3. Use stripe.webhooks.constructEvent(body, sigHeader, webhookSecret) to verify
4. On verification failure: return 401 with generic error (no details leaked)
5. On success: attach verified event to req.stripeEvent and call next()
6. Apply this middleware to the POST /api/billing/webhook route BEFORE any handlers
7. Ensure raw body is preserved (use express.raw({ type: 'application/json' }) or similar) since Stripe needs the exact raw body for verification

Acceptance: POST /api/billing/webhook returns 401 for unsigned/tampered payloads. Only cryptographically verified Stripe events reach handlers.

---

Generated by CEO Planner (priority: 1)

SECURITY CRITICAL: The compliancebot billing webhook route has no signature verification. Without this, any attacker can send fake Stripe events to create subscriptions, grant access, or corrupt billing state. This is the #1 OWASP API security risk. Implementation: 1. Create src/middleware/verify-stripe-signature.ts 2. Read Stripe-Signature header from incoming request 3. Use stripe.webhooks.constructEvent(body, sigHeader, webhookSecret) to verify 4. On verification failure: return 401 with generic error (no details leaked) 5. On success: attach verified event to req.stripeEvent and call next() 6. Apply this middleware to the POST /api/billing/webhook route BEFORE any handlers 7. Ensure raw body is preserved (use express.raw({ type: 'application/json' }) or similar) since Stripe needs the exact raw body for verification Acceptance: POST /api/billing/webhook returns 401 for unsigned/tampered payloads. Only cryptographically verified Stripe events reach handlers. --- *Generated by CEO Planner (priority: 1)*

pook added the

agent-task

label 2026-04-13 01:03:34 -04:00

pook commented 2026-04-13 07:10:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 6h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 6h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 07:20:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 6h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 6h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 07:30:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 6h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 6h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 07:40:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 7h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 7h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 07:50:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 7h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 7h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 08:00:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 7h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 7h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 08:10:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 7h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 7h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 08:20:07 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 7h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 7h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 08:30:07 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 7h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 7h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 08:40:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 8h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 8h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 08:50:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 8h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 8h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook referenced this issue 2026-04-13 08:53:28 -04:00

Add webhook signature verify to billing routes before event processing #1249

pook commented 2026-04-13 09:00:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 8h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 8h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 09:10:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 8h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 8h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 09:20:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 8h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 8h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 09:30:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 8h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 8h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook commented 2026-04-13 09:40:06 -04:00

Author

Owner

Copy link

⚠️ Stale Task Alert — This task has been open for 9h with no associated PR.

Possible causes:

• Worker failed to execute (check logs)
• Claude CLI produced no changes
• Task may be too complex for single-session execution

The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped.

— CEO Planner (automated)

⚠️ **Stale Task Alert** — This task has been open for 9h with no associated PR. Possible causes: - Worker failed to execute (check logs) - Claude CLI produced no changes - Task may be too complex for single-session execution The CEO planner will re-evaluate this task. If it remains stale for 24h+, it will be closed and re-scoped. *— CEO Planner (automated)*

pook referenced this issue 2026-04-13 09:42:12 -04:00

Batch close 8 stale billing issues #1229-#1236 #1254

pook referenced this issue 2026-04-13 09:43:44 -04:00

Add Stripe webhook signature verification to src/billing/routes/webhook.ts #1258

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

feat/ux-remediation

master

agent-task/681

agent-task/mount-billing-api-prefix

agent-task/772

agent-task/769

agent-task/760

agent-task/756

agent-task/757

agent-task/703

agent-task/702

agent-task/688

agent-task/684

agent-task/683

agent-task/674

agent-task/668

feat/simple-health-endpoint

agent-task/663

agent-task/658

agent-task/653

agent-task/651

feat/api-billing-checkout

agent-task/650

agent-task/641

agent-task/639

agent-task/638

feat/login-brute-force-protection

agent-task/634

feat/generate-retry-tests

agent-task/625

agent-task/622-validate-openai-responses

agent-task/615-csrf-token-validation

agent-task/614

agent-task/612

agent-task/611

agent-task/606

agent-task/597

agent-task/596

agent-task/588

agent-task/583

agent-task/575

agent-task/574

agent-task/571

agent-task/570

agent-task/562

agent-task/561

agent-task/556-npm-audit-fix

agent-task/537

agent-task/533

agent-task/524

agent-task/518

agent-task/517

agent-task/516

agent-task/513

agent-task/512

agent-task/508

feat/llm-error-handling-tests

agent-task/483

feat/openai-retry-502

agent-task/478

agent-task/477

feat/csrf-double-submit

agent-task/468

feat/error-handler-middleware

feat/global-request-timeout

agent-task/454

agent-task/453

agent-task/449

feat/llm-timeout-504

feat/sanitize-generate-inputs

fix/body-limit-1mb-test

feat/openai-error-handling

agent-task/426

agent-task/425

agent-task/421

agent-task/420

agent-task/419

agent-task/408

agent-task/406

agent-task/407

feat/zod-generate-validation

agent-task/401

agent-task/397

agent-task/391

agent-task/390

feat/https-redirect-middleware

agent-task/388

agent-task/360

feat/generate-1mb-body-limit

feat/request-timeout

feat/checkout-rate-limit

feat/webhook-rate-limit

feat/centralized-error-handler

agent-task/345

agent-task/342

agent-task/341

agent-task/337

feat/generate-rate-limit

agent-task/332

agent-task/331

agent-task/329

agent-task/325

agent-task/324

feat/single-stage-dockerfile

feat/jest-typecheck-ci-gate

feat/rebase-open-prs-script

fix/unblock-pr-pipeline

agent-task/251

feat/deploy-migrations-on-startup

agent-task/247

agent-task/242

agent-task/241

agent-task/236

fix/close-duplicate-issues

agent-task/237

agent-task/235

agent-task/232

agent-task/231

agent-task/228

agent-task/227

agent-task/222

agent-task/221

feat/stripe-checkout-endpoint

fix/134-sanitize-ai-output

agent-task/212

agent-task/211

test/export-render-unit-tests

agent-task/206

agent-task/205

feat/download-token-utility

feat/security-headers-v2

agent-task/196

fix/env-var-validation

feat/health-endpoint-tests

feat/cors-middleware

agent-task/185

agent-task/184

agent-task/180

feat/pr-triage-workflow

agent-task/177

feat/dockerfile-deploy

feature/131-api-key-auth

feat/graceful-shutdown

agent-task/170

feat/pr-triage-script

agent-task/166

feat/ccpa-privacy-policy

feat/auto-migrate-on-startup

feat/auto-rebase-workflow

feat/openai-timeout-guard

agent-task/154

agent-task/155

feat/body-size-limit-generate

feat/health-endpoint

ci/pr-checks

agent-task/145

feat/startup-env-validation

agent-task/141

feat/stripe-document-checkout

fix/116-sanitize-ai-generated-content

feat/document-validation-41

feat/api-key-auth-middleware

feature/document-generator-unit-tests

feature/openai-retry-logic

feature/auto-merge-script

feature/ci-auto-labeling

fix/llm-response-null-checks

feat/generate-smoke-tests

feature/request-logging-middleware

feature/csrf-protection

feature/request-id-middleware

feature/cors-allowlist

feature/rate-limit-generate

feature/citation-scanner-and-disclaimer

feature/input-length-validation

feat/ci-quality-gate

fix/stripe-webhook-raw-body

feat/ci-pr-checks

fix/webhook-raw-body-preservation

feat/ci-workflow

feature/71-raw-body-webhook

feature/template-rendering-tests

feature/stripe-document-webhook

feat/security-headers

feat/stripe-webhook-raw-body

feat/startup-migrations

feature/ai-generation-timeout

feature/dependency-audit-ci

feat/webhook-idempotency

feature/body-size-limit

feature/startup-env-validation

ci/add-pr-pipeline

feature/auth-middleware

feature/ccpa-optout-endpoint

feature/async-document-generation

feature/stripe-checkout-paywall

feature/post-generation-validation

feature/llm-retry-mechanism

feature/document-history

feature/prometheus-metrics

feature/dpa-document-type

feature/input-validation-sanitization

feature/document-email-send

feature/api-health-endpoint

No results found.

Labels

Clear labels   

agent-task

Task for autonomous agent execution

  

agent-task

Paperclip autonomous agent task

No labels

agent-task

agent-task

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

pook/compliancebot#1229

No description provided.